pin pyyaml to python2 compatible version #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tupaschoal
approved these changes
Oct 8, 2021
|
Seems to have worked fine now @adam-bloom :) PS: Weirdly MAC takes A LOT longer to build than the windows ones, I'm guessing it's caching. |
Yeah, there’s no caching on the Mac build. It also builds both architectures serially (intel and M1) where as the windows jobs do that in parallel. I figured we don’t build these all that often right now, so we have better things to do than optimize it further. |
|
Agreed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well...not related to my last change...but also a one line fix as I hoped.
Looks like https://pypi.org/project/PyYAML/6.0b1/#history was released on pypi on Monday (which drops python2.7 support: yaml/pyyaml#550) - just in time to wreak havoc here! I've added an explicit version pin to 5.4.1. Hopefully, duktape will eventually be updated to be python3 compatible - looks like the vcpkg folks are interested in svaarala/duktape#1794 as well! (The vcpkg port attempts to install pyyaml if it is not present, but it falls into the same trap now, so removing this separate install step was not successful.)
@tupaschoal mind giving this another go? Thanks!