Fix for SubmodelComp indexing bug. #3239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robfalck
requested changes
May 17, 2024
johnjasa
approved these changes
May 17, 2024
|
Thanks for this fix and cleanup, Bret! We really appreciate it. |
robfalck
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SubmodelComp outputs were not being properly copied to the outer model in some cases.
For now, variables exposed as inputs or outputs of a SubmodelComp are not allowed to be distributed.
Related Issues
Backwards incompatibilities
The default value of the
do_coloringoption for SubmodelComp has been changed to False.New Dependencies
None