Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fixture varytec/led-theater-spot-120-fc #3977

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

FloEdelmann
Copy link
Member

  • Add fixture varytec/led-theater-spot-120-fc

Fixture warnings / errors

  • varytec/led-theater-spot-120-fc
    • ❌ Mode '6 CH' should have 6 channels according to its name but actually has 2.
    • ❌ Mode '6 CH' should have 6 channels according to its shortName but actually has 2.
    • ❌ Category 'Color Changer' invalid since there are no ColorPreset and less than two ColorIntensity capabilities and no Color wheel slots.
    • ⚠️ Mode '6 CH' should have shortName '6ch' instead of '6 CH'.
    • ⚠️ Mode '6 CH' should have shortName '6ch' instead of '6 CH'.

Thank you jean7111!

@FloEdelmann FloEdelmann added new-fixture Request or implementation to add a new fixture definition. via-editor Opened via the editor on the open-fixture-library.org website. labels May 19, 2024
Copy link

Export files validity

(Output of test script tests/github/exports-valid.js.)

Test the exported files of selected fixtures against the plugins' export tests.
You can run a plugin's export tests by executing:
$ node cli/run-export-test.js -p <plugin name> <fixtures>

✔️ varytec / led-theater-spot-120-fc: d-light / attributes-correctness
  • ✔️ varytec/led-theater-spot-120-fc-6 CH.xml
✔️ varytec / led-theater-spot-120-fc: dmxcontrol3 / channel-numbers
  • ✔️ varytec-led-theater-spot-120-fc-6-CH.xml
✔️ varytec / led-theater-spot-120-fc: dragonframe / json-schema-conformity
  • ✔️ varytec/led-theater-spot-120-fc.json
  • ✔️ manufacturers.json
✔️ varytec / led-theater-spot-120-fc: millumin / json-schema-conformity
  • ✔️ varytec/led-theater-spot-120-fc.json
varytec / led-theater-spot-120-fc: qlcplus_4.12.2 / fixture-tool-validation
  • ❌ fixtures/Varytec-LED-Theater-Spot-120-FC.qxfNamespace(map=False, convert=None, validate=['.']) Starting validation ./manufacturer/fixture.qxf: Invalid physical dimensions detected 1 definitions processed. 1 errors detected
varytec / led-theater-spot-120-fc: qlcplus_4.12.2 / xsd-schema-conformity
  • ❌ fixtures/Varytec-LED-Theater-Spot-120-FC.qxfElement '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Width': '0' is not a valid value of the atomic type 'xs:positiveInteger'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Height': '0' is not a valid value of the atomic type 'xs:positiveInteger'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Depth': '0' is not a valid value of the atomic type 'xs:positiveInteger'.

@kengruven
Copy link
Contributor

kengruven commented May 20, 2024

The "Red" channel here is just wrong.

Also, this looks exactly like varytec/led-theater-spot-100 (merged by #829) but with 20% higher power. Could we simply add a note on that fixture that it works for both? Or change its title to "LED Theater Spot 100/120"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-fixture Request or implementation to add a new fixture definition. via-editor Opened via the editor on the open-fixture-library.org website.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants