New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move expose ports to constructor to avoid duplicate key exception #13212

Merged

KyleAure merged 1 commit into OpenLiberty:integration from KyleAure:bb276269-move-exposeport-to-constructor

Jul 30, 2020

Member

KyleAure commented Jul 28, 2020

Issue originally resolved in Test Containers repo under PR testcontainers/testcontainers-java#2473

But using a custom SQLServerContainer in Liberty to avoid having to provide an accept license file. Applying fix to this custom SQLServerContainer.


          Move expose ports to constructor to avoid duplicate key exception

310d33a

KyleAure added the team:Zombie Apocalypse label

KyleAure self-assigned this

LibbyBot added CLA Signed noproductcode labels

LibbyBot commented Jul 28, 2020

Code analysis and actions

DO NOT DELETE THIS COMMENT.

Please describe in a separate comment how you tested your changes.
1 test infrastructure code files were changed.
Test failures/errors in the build could be due to these changes.

olendvcook approved these changes

View reviewed changes

Member Author

KyleAure commented Jul 28, 2020

#build

LibbyBot commented Jul 28, 2020

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_CxXLQNDkEeqmIcsdsdUKbw

Target locations of links might be accessible only to IBM employees.

LibbyBot commented Jul 28, 2020

Your Open Liberty build results are ready for viewing.

Unit test results are at http://public.dhe.ibm.com/ibmdl/export/pub/software/openliberty/runtime/personal/_CxXLQNDkEeqmIcsdsdUKbw/junit/index.html.
Gradle log and image zip are at http://public.dhe.ibm.com/ibmdl/export/pub/software/openliberty/runtime/personal/_CxXLQNDkEeqmIcsdsdUKbw.

LibbyBot commented Jul 29, 2020

The build KyleAure-13212-20200728-1620
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_CxXLQNDkEeqmIcsdsdUKbw
completed and has errors or failures.

For help analyzing your personal build, go to https://cognitive.hursley.ibm.com/buildAnalysis.html?uuid=_CxXLQNDkEeqmIcsdsdUKbw

KyleAure merged commit 6e2d610 into OpenLiberty:integration

KyleAure deleted the bb276269-move-exposeport-to-constructor branch

July 30, 2020 14:31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment