Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update several dependencies #26

Merged
merged 2 commits into from Apr 26, 2023
Merged

Conversation

cherylking
Copy link
Member

@cherylking cherylking commented Feb 15, 2023

Need to update several dependencies:

  • Update from 1.7.0.Alpha13 to 1.7.0.Alpha14 for org.jboss.arquillian:arquillian-bom
  • Update from 6.13.1 to 7.5.1 for org.testng:testng
  • Update from 2.1.1 to 2.1.2 for arquillian-liberty-managed-jakarta and arquillian-liberty-remote-jakarta

@cherylking
Copy link
Member Author

cherylking commented Feb 15, 2023

In addition to the builds failing with an slf4j related error, the update in TestNG dependency version also seems to break running with Java 8 (see here).

Just confirmed on this page the following Java requirements:

Requirements
TestNG Upto v7.5: JDK 8 or higher.

TestNG v7.6.0 and above: JDK 11 or higher.

@jhanders34
Copy link
Member

@tevans78 I assume you will also have this issue with running 7.7.1 with Java 8.

@jhanders34
Copy link
Member

In addition to the builds failing with an slf4j related error,

It looks like 7.7 has a dependency in the pom.xml that does not exist in 6.13.1.

@cherylking
Copy link
Member Author

@tevans78 Any idea how I should proceed? The update to the TestNG dependency version breaks running with Java 8, and fails when running with Java 11 and 17 due to an unsatisfied dependency on slf4j.

@jhanders34
Copy link
Member

We are going to need the change ported to 7.5 stream and a 7.5.1 version created it would seem. As to the slf4j, you will need to add slf4j dependencies in your pom.xml.

@cherylking
Copy link
Member Author

We are going to need the change ported to 7.5 stream and a 7.5.1 version created it would seem.

@jhanders34 Do you know which change that went into 7.7.0 needs to be ported to the 7.5 stream? I want to track its progress or raise it as an issue if it hasn't been yet.

@cherylking
Copy link
Member Author

Think I found the relevant TestNG PR here. Someone already asked for it to be ported to 7.5. I added a comment supporting that request.

@tevans78
Copy link
Member

Ah, this is annoying, I hadn't spotted the Java 11 requirement. Looking at the original testng repo and some of the comments in the PR, it does not look like they will be particularly quick to patch older versions. We might have to create our own fork and create our own 7.5 service branch where we can apply the fix. Fortunately the change looks pretty simple.

@cherylking
Copy link
Member Author

cherylking commented Apr 26, 2023

Updating here that a 7.5.1 of TestNG has been published with the needed fix. That should resolve the Java 8 issue I was having. Will update this PR with that version of TestNG.

https://groups.google.com/g/testng-users/c/71NlECG4AZ0/m/k64pMoFSAwAJ?pli=1

@cherylking
Copy link
Member Author

Could not update to use the 23.0.0.3 runtime since there is no wlp-webProfile9 available. Need to make that change when the tests are updated to use EE 10. Opened issue #27 for that.

@cherylking cherylking merged commit bb2ec65 into OpenLiberty:main Apr 26, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants