Fix bug in Capability invoke #2239
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oh yes, of course |
velo
reviewed
Nov 20, 2023
| @@ -57,7 +57,7 @@ static Object enrich(Object componentToEnrich, | |||
| static Object invoke(Object target, Capability capability, Class<?> capabilityToEnrich) { | |||
| return Arrays.stream(capability.getClass().getMethods()) | |||
| .filter(method -> method.getName().equals("enrich")) | |||
| .filter(method -> method.getReturnType().isAssignableFrom(capabilityToEnrich)) | |||
| .filter(method -> method.getReturnType() == capabilityToEnrich) | |||
There was a problem hiding this comment.
I don't think this will work for Feign, all enrichers are based on interfaces....
I even wonder how this didn't broke any unit test.
There was a problem hiding this comment.
I don't think this will work for Feign, all enrichers are based on interfaces....
I even wonder how this didn't broke any unit test.
I think you're right, if you look at the feign application as a whole, this rarely happens, since I'm thinking about the logic of this place in terms of this method, thank you, I'll close this pull request,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to fix the bug, capability can't enrich the correct method
issue:#2237