Micrometer observations #1828

velo · 2022-11-09T20:40:53Z

Alternative micrometer observation using capability

Bumps [json](https://github.com/douglascrockford/JSON-java) from 20220320 to 20220924. - [Release notes](https://github.com/douglascrockford/JSON-java/releases) - [Changelog](https://github.com/stleary/JSON-java/blob/master/docs/RELEASES.md) - [Commits](https://github.com/douglascrockford/JSON-java/commits) --- updated-dependencies: - dependency-name: org.json:json dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps `slf4j.version` from 2.0.2 to 2.0.3. Updates `slf4j-simple` from 2.0.2 to 2.0.3 - [Release notes](https://github.com/qos-ch/slf4j/releases) - [Commits](qos-ch/slf4j@v_2.0.2...v_2.0.3) Updates `slf4j-nop` from 2.0.2 to 2.0.3 - [Release notes](https://github.com/qos-ch/slf4j/releases) - [Commits](qos-ch/slf4j@v_2.0.2...v_2.0.3) Updates `slf4j-api` from 2.0.2 to 2.0.3 - [Release notes](https://github.com/qos-ch/slf4j/releases) - [Commits](qos-ch/slf4j@v_2.0.2...v_2.0.3) Updates `slf4j-jdk14` from 2.0.2 to 2.0.3 - [Release notes](https://github.com/qos-ch/slf4j/releases) - [Commits](qos-ch/slf4j@v_2.0.2...v_2.0.3) --- updated-dependencies: - dependency-name: org.slf4j:slf4j-simple dependency-type: direct:development update-type: version-update:semver-patch - dependency-name: org.slf4j:slf4j-nop dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.slf4j:slf4j-api dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.slf4j:slf4j-jdk14 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps `kotlin.version` from 1.7.10 to 1.7.20. Updates `kotlin-stdlib-jdk8` from 1.7.10 to 1.7.20 - [Release notes](https://github.com/JetBrains/kotlin/releases) - [Changelog](https://github.com/JetBrains/kotlin/blob/v1.7.20/ChangeLog.md) - [Commits](JetBrains/kotlin@v1.7.10...v1.7.20) Updates `kotlin-reflect` from 1.7.10 to 1.7.20 - [Release notes](https://github.com/JetBrains/kotlin/releases) - [Changelog](https://github.com/JetBrains/kotlin/blob/v1.7.20/ChangeLog.md) - [Commits](JetBrains/kotlin@v1.7.10...v1.7.20) Updates `kotlin-maven-plugin` from 1.7.10 to 1.7.20 --- updated-dependencies: - dependency-name: org.jetbrains.kotlin:kotlin-stdlib-jdk8 dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.jetbrains.kotlin:kotlin-reflect dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.jetbrains.kotlin:kotlin-maven-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps asm from 9.3 to 9.4. --- updated-dependencies: - dependency-name: org.ow2.asm:asm dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

marcingrzejszczak

I've added small remarks but in general your suggestion looks much better than mine!

marcingrzejszczak · 2022-11-10T10:31:11Z

micrometer/src/main/java/feign/micrometer/DefaultFeignObservationConvention.java

+  }
+
+  String getMethodString(@Nullable Request request) {
+    return request.httpMethod().name();


If a request is @Nullable you might get NPE here (although I doubt that it would be the case in Feign)

marcingrzejszczak · 2022-11-10T10:31:54Z

micrometer/src/main/java/feign/micrometer/FeignObservationConvention.java

+ * {@link ObservationConvention} for Feign.
+ *
+ * @since 1.10.0
+ * @see DefaultApacheHttpClientObservationConvention


Why this @see ? Also @since 1.10.0 seems like a copy from micrometer ;)

I'm not sure either, you wrote that =)

marcingrzejszczak · 2022-11-10T10:32:06Z

micrometer/src/main/java/feign/micrometer/FeignContext.java

+ * A {@link SenderContext} for Feign.
+ *
+ * @author Marcin Grzejszczak
+ * @since 1.10.0


@since 13.0 I guess?

FWIW, Feign next release going to be 12.1

marcingrzejszczak · 2022-11-10T10:32:20Z

micrometer/src/main/java/feign/micrometer/FeignObservationDocumentation.java

+/**
+ * {@link ObservationDocumentation} for Feign.
+ * 
+ * @since 1.10.0


@since 13.0 ?

marcingrzejszczak · 2022-11-10T10:36:33Z

micrometer/src/main/java/feign/micrometer/FeignObservationDocumentation.java

+    STATUS {
+      @Override
+      public String asString() {
+        return "status";


I've made a mistake in the original PR, let's go with the semantic conventions from OTel https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/http.md

method -> http.method

status -> http.status_code

target.port -> net.peer.port

target.host -> net.peer.name

uri -> http.url

I don't see scheme in the conventions so we can go with http.scheme

What if you merge my chances into your PR and then you can do the required changes?

marcingrzejszczak · 2022-11-10T10:39:23Z

micrometer/src/main/java/feign/micrometer/DefaultFeignObservationConvention.java

+/**
+ * Default implementation of {@link FeignObservationConvention}.
+ *
+ * @since 1.10.0


@since 13.0 ?

marcingrzejszczak · 2022-11-14T11:39:56Z

Merged this PR to this one #1760

marcingrzejszczak and others added 25 commits September 21, 2022 11:29

WIP on Micrometer Observations

212fdf2

Added verification that metrics are measured

5e8192c

Fixed formatting

e23a805

Fixed wrong status code method call

97b23e9

Converted to using around

9119a61

Fixed compilation issues

8832aff

prepare release 11.10

75f5a97

[ci skip] updating versions to next development iteration 11.11-SNAPSHOT

6a213cf

Preparing for next development version

4a9d1fb

Updated to latest micrometer changes

f02d3ca

Enriches via clientInterceptors

2551952

Fixed the error in the DEFAULT instance

2392312

Reverts enriching of CLientInterceptor to achieve observability

24ae435

Applied latest changes of Micrometer

ba413e8

Removing conflicts

734272c

Polish

0421e72

Upgraded Micrometer to 1.10.0'

91ec111

Alternative micrometer observation using capability

0784382

Ban 'repositories'

80f2e77

Merge remote-tracking branch 'origin/master' into micrometerObservations

a2f21fa

Merge branch 'master' into micrometerObservations

f1524cb

velo mentioned this pull request Nov 9, 2022

Micrometer Observations #1760

Merged

velo requested review from kdavisk6 and wplong11 and removed request for kdavisk6 November 9, 2022 21:09

velo requested a review from vitalijr2 November 9, 2022 21:09

marcingrzejszczak reviewed Nov 10, 2022

View reviewed changes

wplong11 approved these changes Nov 10, 2022

View reviewed changes

Merge branch 'master' into micrometerObservations

9f7a144

kdavisk6 approved these changes Nov 13, 2022

View reviewed changes

velo closed this Nov 14, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Micrometer observations #1828

Micrometer observations #1828

velo commented Nov 9, 2022

marcingrzejszczak left a comment

marcingrzejszczak Nov 10, 2022

marcingrzejszczak Nov 10, 2022

velo Nov 10, 2022

marcingrzejszczak Nov 10, 2022

velo Nov 10, 2022

marcingrzejszczak Nov 10, 2022

marcingrzejszczak Nov 10, 2022

velo Nov 10, 2022

marcingrzejszczak Nov 10, 2022

marcingrzejszczak Nov 10, 2022

marcingrzejszczak commented Nov 14, 2022

Micrometer observations #1828

Micrometer observations #1828

Conversation

velo commented Nov 9, 2022

marcingrzejszczak left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

marcingrzejszczak commented Nov 14, 2022