External generator settings (new implementation) #10
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| /* | ||
| * This file is part of Cubic World Generation, licensed under the MIT License (MIT). | ||
| * | ||
| * Copyright (c) 2015 contributors | ||
| * | ||
| * Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| * of this software and associated documentation files (the "Software"), to deal | ||
| * in the Software without restriction, including without limitation the rights | ||
| * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| * copies of the Software, and to permit persons to whom the Software is | ||
| * furnished to do so, subject to the following conditions: | ||
| * | ||
| * The above copyright notice and this permission notice shall be included in | ||
| * all copies or substantial portions of the Software. | ||
| * | ||
| * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
| * THE SOFTWARE. | ||
| */ | ||
| package io.github.opencubicchunks.cubicchunks.cubicgen.common.gui; | ||
|
|
||
| import io.github.opencubicchunks.cubicchunks.cubicgen.customcubic.CustomCubicWorldType; | ||
| import io.github.opencubicchunks.cubicchunks.cubicgen.customcubic.CustomGeneratorSettings; | ||
| import io.github.opencubicchunks.cubicchunks.cubicgen.customcubic.gui.CustomCubicGui; | ||
| import net.minecraft.client.Minecraft; | ||
| import net.minecraft.client.gui.GuiListWorldSelectionEntry; | ||
| import net.minecraft.client.gui.GuiWorldSelection; | ||
| import net.minecraft.world.storage.ISaveHandler; | ||
| import net.minecraft.world.storage.WorldInfo; | ||
| import net.minecraftforge.client.event.GuiScreenEvent; | ||
| import net.minecraftforge.fml.common.eventhandler.SubscribeEvent; | ||
|
|
||
| /** | ||
| * This GUI handler serve a sole purpose to copy CustomCubic generator settings | ||
| * in case if player making a copy of such world | ||
| */ | ||
| public class GuiEventHandler { | ||
|
|
||
| @SubscribeEvent | ||
| public void onButtonPressed(GuiScreenEvent.ActionPerformedEvent.Pre action) { | ||
| if (action.getGui() instanceof GuiWorldSelection) { | ||
| if (!action.getButton().enabled) | ||
| return; | ||
| // "Recreate world" has button id = 5 | ||
| if (action.getButton().id != 5) | ||
| return; | ||
| GuiWorldSelection gui = (GuiWorldSelection) action.getGui(); | ||
| if (gui.selectionList.getSelectedWorld() == null) | ||
| return; | ||
| GuiListWorldSelectionEntry entry = gui.selectionList.getSelectedWorld(); | ||
| ISaveHandler isavehandler = Minecraft.getMinecraft().getSaveLoader() | ||
| .getSaveLoader(entry.worldSummary.getFileName(), false); | ||
| WorldInfo worldinfo = isavehandler.loadWorldInfo(); | ||
|
|
||
| if (worldinfo == null || !(worldinfo.getTerrainType() instanceof CustomCubicWorldType)) | ||
| return; | ||
| String json = CustomGeneratorSettings.loadJsonStringFromSaveFolder(isavehandler); | ||
| isavehandler.flush(); | ||
| if (json != null) { | ||
| CustomCubicWorldType.pendingCustomCubicSettingsJsonString = json; | ||
|
There was a problem hiding this comment. I really don't like that static field here. Verifying that this field has the right value at the right time is nearly impossible without actually trying every possibility. Instead I would suggest just mixing into This also should remove the need for This would also allow to actually store the loaded preset text somewhere instead of loading it from disk each time it's needed. If you actually inject in the right place, you can almost completely hide the fact that the preset is not saved in level.dat, by just not saving that part into level.dat for CustomCubic worlds, and instead have code somewhere else that saves it. |
||
| } | ||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why a comment instead of making a
private static final intfield?