#2684 [CT] Improve stocks/sia error handling, abstract duplicate code

[catalintoma]

Description

• Improve error message when YF doesn't return needed data, abstract duplicate code
• Fixes [Bug] /Stocks/SIA - load function doesn't work. Error: 'NoneType' object is not subscriptable #2684

How has this been tested?

• Extended unit tests

Checklist:

• Update our tests following these guidelines.
• Make sure you are following our CONTRIBUTING guidelines.

Others

• I have performed a self-review of my own code.
• I have commented my code, particularly in hard-to-understand areas.

[colin99d]

Nice work!! Also thanks for adding tests as well!

[colin99d]

Once tests and linters are good I can merge. Let me know if you need any help.

[catalintoma]

@colin99d

I noticed this step failed quit fast
Tests / Base Tests - Ubuntu-latest - Python 3.9 (pull_request)

Also wanted to ask if there is any way the linter (other tooling?) detect duplicate code? I think on this controller there were around 40 lines of code duplicated!

If it's not something extremely hard, I would raise an improvement issue for this, I noticed this "code smell" in many places

[colin99d]

Hmm weird. It looks like Github actions is failing. I will try to run again later.

[colin99d]

Also, I believe pylint can be configured to check for code duplication. But when I last used it, we got way too many false positives.

[catalintoma]

@colin99d can you kick the CI again? Seems like one still failed

[colin99d]

actions/checkout#944

Something in our CI is broken, but its not our fault. I am downgrading the version we use and then tests should run.