-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shed importlib resources legacy #208
Shed importlib resources legacy #208
Conversation
jaraco
commented
Jul 14, 2023
- ⚫ Fade to black.
- Switch to non-legacy API for loading resources. Fixes deprecated importlib_resources.path #206.
The "Fade to black" commit is there because my editor is configured to save in black style if black is configured for the project (which this one is). Feel free to bypass that commit as you wish. |
I have not tested this change, and I see there aren't CI tests, so please do test the implementation. I would also recommend to import the modules "as" something, e.g. |
Oh, I see that some tests did run. That's encouraging. I ran the tests locally and there are a few failures, but none related to resources as far as I can tell:
And I've confirmed I get the same set of errors/failures on master. |
Great, thanks! I cherry-picked the real fix and skipped the "fade to black" as we actually use I also added a small test to cover actually reading that 'default.py' file. |
about those errors you see in the test run: thanks anyway for contributing! |