Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] add subscriptionId and url to webhook payloads #1175

Merged
merged 1 commit into from
May 2, 2024

Conversation

jkasten2
Copy link
Member

@jkasten2 jkasten2 commented May 1, 2024

Description

One-Line Summary

Add subscriptionId and url to webhook payloads; clicked, dismissed, and willDisplay.

Details

Validation

Tests

Tested sending a few notifications ensuring the clicked, dismissed, and willDisplay fire with the new subscriptionId and url values filled in. In also tested the clicked with action buttons, ensuring the url in the webhook was the one clicked.

Info

Checklist

  • All the automated tests pass or I explained why that is not possible
  • I have personally tested this on my machine or explained why that is not possible
  • I have included test coverage for these changes or explained why they are not needed

Programming Checklist
Interfaces:

  • Don't use default export
  • New interfaces are in model files

Functions:

  • Don't use default export
  • All function signatures have return types
  • Helpers should not access any data but rather be given the data to operate on.

Typescript:

  • No Typescript warnings
  • Avoid silencing null/undefined warnings with the exclamation point

Other:

  • Iteration: refrain from using elem of array syntax. Prefer forEach or use map
  • Avoid using global OneSignal accessor for context if possible. Instead, we can pass it to function/constructor so that we don't call OneSignal.context

Screenshots

Info

Checklist

  • I have included screenshots/recordings of the intended results or explained why they are not needed

Related Tickets



This change is Reviewable

@jkasten2 jkasten2 merged commit 79d3c4b into main May 2, 2024
4 checks passed
@jkasten2 jkasten2 deleted the fix/webhook-payload-missing-fields branch May 2, 2024 16:49
@jkasten2 jkasten2 mentioned this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants