Merge pull request #1174 from OneSignal/fix/webhook-url-params

[Fix] Webhook dismissed not firing, and willDisplay when set from the dashboard
OneSignal · Apr 30, 2024 · 4472be3 · 4472be3
2 parents 749b04a + 0e919a7
commit 4472be3
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/shared/helpers/ConfigHelper.ts b/src/shared/helpers/ConfigHelper.ts
@@ -581,7 +581,7 @@ export class ConfigHelper {
           webhooks: {
             cors: serverConfig.config.webhooks.corsEnable,
             'notification.willDisplay':
-              serverConfig.config.webhooks.notificationWillDisplayHook,
+              serverConfig.config.webhooks.notificationDisplayedHook,
             'notification.clicked':
               serverConfig.config.webhooks.notificationClickedHook,
             'notification.dismissed':

diff --git a/src/shared/models/AppConfig.ts b/src/shared/models/AppConfig.ts
@@ -234,7 +234,7 @@ export interface ServerAppConfig {
       corsEnable?: boolean;
       notificationClickedHook?: string;
       notificationDismissedHook?: string;
-      notificationWillDisplayHook?: string;
+      notificationDisplayedHook?: string;
     };
     integration: {
       kind: ConfigIntegrationKind;

diff --git a/src/sw/webhooks/notifications/payloads/OSWebhookPayloadNotificationDismiss.ts b/src/sw/webhooks/notifications/payloads/OSWebhookPayloadNotificationDismiss.ts
@@ -4,7 +4,7 @@ import { IOSNotification } from '../../../../shared/models/OSNotification';
 export class OSWebhookPayloadNotificationDismiss
   implements IOSWebhookEventPayload
 {
-  readonly event: string = 'notification.dismiss';
+  readonly event: string = 'notification.dismissed';
   readonly notificationId: string;
   readonly heading?: string;
   readonly content: string;