Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement LMS #400

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Implement LMS #400

wants to merge 1 commit into from

Conversation

Ogeon
Copy link
Owner

@Ogeon Ogeon commented May 12, 2024

Add support for the LMS color space.

Closed Issues

Copy link

codspeed-hq bot commented May 12, 2024

CodSpeed Performance Report

Merging #400 will degrade performances by 62.33%

Comparing lms (2be4068) with master (148f406)

Summary

❌ 2 regressions
✅ 44 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark master lms Change
matrix_inverse 215.6 ns 572.2 ns -62.33%
hsv to hsl 16 µs 18.2 µs -12.18%

Copy link

codecov bot commented May 12, 2024

Codecov Report

Attention: Patch coverage is 83.39223% with 47 lines in your changes are missing coverage. Please review.

Project coverage is 83.34%. Comparing base (148f406) to head (2be4068).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #400      +/-   ##
==========================================
- Coverage   83.35%   83.34%   -0.01%     
==========================================
  Files         125      127       +2     
  Lines       20184    20418     +234     
  Branches    20184    20418     +234     
==========================================
+ Hits        16824    17018     +194     
- Misses       3203     3243      +40     
  Partials      157      157              
Components Coverage Δ
palette 83.44% <84.06%> (-0.02%) ⬇️
palette_derive 81.98% <78.12%> (+0.24%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement LMS color space and CVD simulation
1 participant