Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(bench): make benchmarks work again #398

Merged
merged 1 commit into from
May 1, 2024

Conversation

adriencaccia
Copy link
Contributor

@adriencaccia adriencaccia commented Apr 29, 2024

Make benchmarks and CodSpeed work again.

Implemented after this discussion: #391 (comment)

This is not a long term fix, but it has the merit of making everything work again.

Copy link

codspeed-hq bot commented Apr 29, 2024

CodSpeed Performance Report

Merging #398 will improve performances by 13.89%

Comparing adriencaccia:fix/benchmark-load-data (ac02f53) with master (7fe4d87)

Summary

⚡ 1 improvements
✅ 45 untouched benchmarks

Benchmarks breakdown

Benchmark master adriencaccia:fix/benchmark-load-data Change
multiply_3x3 455.6 ns 400 ns +13.89%

@Ogeon Ogeon merged commit 148f406 into Ogeon:master May 1, 2024
16 checks passed
@Ogeon
Copy link
Owner

Ogeon commented May 1, 2024

Thank you!

@adriencaccia adriencaccia deleted the fix/benchmark-load-data branch May 1, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants