Initial implementation of wasmbinary to wat #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuacolvin0
commented
Mar 11, 2024
arbitrator/prover/src/print.rs
Outdated
| for (i, type_idx) in self.functions.iter().enumerate() { | ||
| let i1 = i as u32; | ||
|
|
||
| let export_str = match self.maybe_func_name(i1 + 1) { |
There was a problem hiding this comment.
Concerned that incorrect index is being used here
joshuacolvin0
changed the title
rachel-bousfield
changed the title
rachel-bousfield
requested changes
Mar 22, 2024
There was a problem hiding this comment.
Made some simplifications & fixes. There's just two things to note
- The reason function names are sometimes wrong is that we're not considering imports. If a WASM has no imports, then the names are correct. However if there's
nimports, the names will be shiftednaway. Fixing this requires changingfunc_name,maybe_func_name, etc to distinguish imports from local functions. - Some of the changes affect
Moduleprinting, which may be worth checking again and fixing where visually affected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation. The wasm instructions are currently not formatted in wat format, so everything is provided, but result is not valid wat.
Resolves STY-22