feat: new destination chain dropdown #1602
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
brtkx
commented
Mar 26, 2024
| return networksToShow | ||
| } | ||
|
|
||
| const groupedNetworks = [] |
There was a problem hiding this comment.
We should always have at least one core chain but just in case we only show groups if they have at least one chain
…e into new-destination-chain-dropdown
brtkx
commented
Apr 17, 2024
| @@ -573,6 +625,14 @@ export function TransferPanelMain({ | |||
|
|
|||
| useUpdateUSDCTokenData() | |||
|
|
|||
| type NetworkListboxProps = { | |||
There was a problem hiding this comment.
Moved from NetworkListbox.tsx which got removed.
fionnachan
requested changes
Apr 18, 2024
Comment on lines
+347
to
+354
| <SearchPanel.MainPage className="flex h-full max-w-[500px] flex-col py-4"> | ||
| <NetworksPanel | ||
| chainIds={supportedChainIds} | ||
| selectedChainId={selectedChainId} | ||
| close={() => props.onClose(false)} | ||
| onNetworkRowClick={props.onChange} | ||
| /> | ||
| </SearchPanel.MainPage> |
There was a problem hiding this comment.
something odd with the width
there shouldn't be a horizontal scrollbar
| onClick={onClick} | ||
| > | ||
| <span className="max-w-[220px] truncate text-sm leading-[1.1] md:max-w-[250px] md:text-xl"> | ||
| From: {getNetworkName(selectedChainId)} |
Comment on lines
+628
to
+634
| type NetworkListboxProps = { | ||
| disabled?: boolean | ||
| label: string | ||
| options: Chain[] | ||
| value: Chain | ||
| onChange: (value: Chain) => void | ||
| } |
There was a problem hiding this comment.
this can be deleted because really we only need onChange for both from and to now
Comment on lines
637
to
638
| from: Pick<NetworkListboxProps, 'onChange'> | ||
| to: Omit<NetworkListboxProps, 'label'> |
There was a problem hiding this comment.
i would just do and delete the other props from to in the return object and getDestinationChains because they are called within NetworkSelectionContainer already
Suggested change
| from: Pick<NetworkListboxProps, 'onChange'> | |
| to: Omit<NetworkListboxProps, 'label'> | |
| from: { | |
| onChange: (value: Chain) => void | |
| } | |
| to: { | |
| onChange: (value: Chain) => void | |
| } |
| @@ -429,6 +480,7 @@ export function TransferPanelMain({ | |||
| } | |||
| }, [nativeCurrency, ethL1Balance, ethL2Balance, erc20L1Balances]) | |||
|
|
|||
| const [isTestnetMode] = useIsTestnetMode() | |||
| @@ -66,12 +69,53 @@ import { | |||
| Balances, | |||
| useSelectedTokenBalances | |||
| } from '../../hooks/TransferPanel/useSelectedTokenBalances' | |||
| import { useIsTestnetMode } from '../../hooks/useIsTestnetMode' | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.