feat: show ARB token on all Orbit chains #1475
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| parentChainId, | ||
| childChainId |
There was a problem hiding this comment.
passing chain id fixes the following issue:
user's source chain was an Arbitrum Chain, e.g. Arb One, and destination chain is L3 Orbit
then user switched destination to L1
the L1<->L2 Arb token was not added to bridgeTokens because the chain ids in useArbTokenBridge was still the old pair (Arb One & L3 Orbit) instead of L1 & L2
| if (isArbitrumToken) { | ||
| return true | ||
| } |
There was a problem hiding this comment.
never show the "Import" text for Arb token
| const [networks] = useNetworks() | ||
| const { childChainProvider, parentChainProvider } = | ||
| useNetworksRelationship(networks) | ||
|
|
||
| const { addPendingTransaction } = useTransactionHistory(walletAddress) | ||
|
|
||
| const { | ||
| eth: [, updateEthL1Balance], | ||
| erc20: [, updateErc20L1Balance] | ||
| } = useBalance({ | ||
| provider: l1.provider, | ||
| provider: parentChainProvider, | ||
| walletAddress | ||
| }) | ||
| const { | ||
| eth: [, updateEthL2Balance], | ||
| erc20: [, updateErc20L2Balance] | ||
| } = useBalance({ | ||
| provider: l2.provider, | ||
| provider: childChainProvider, |
There was a problem hiding this comment.
l1 & l2 from params are stale so had to do this after switching chain
might need to check if that causes issues with transfers
There was a problem hiding this comment.
We should probably use that across the entire hook and get rid of l1/l2 in params
There was a problem hiding this comment.
100%
@chrstph-dvx is working on that 😁
| if (!walletAddress) { | ||
| return | ||
| } |
| const [networks] = useNetworks() | ||
| const { childChainProvider, parentChainProvider } = | ||
| useNetworksRelationship(networks) | ||
|
|
||
| const { addPendingTransaction } = useTransactionHistory(walletAddress) | ||
|
|
||
| const { | ||
| eth: [, updateEthL1Balance], | ||
| erc20: [, updateErc20L1Balance] | ||
| } = useBalance({ | ||
| provider: l1.provider, | ||
| provider: parentChainProvider, | ||
| walletAddress | ||
| }) | ||
| const { | ||
| eth: [, updateEthL2Balance], | ||
| erc20: [, updateErc20L2Balance] | ||
| } = useBalance({ | ||
| provider: l2.provider, | ||
| provider: childChainProvider, |
There was a problem hiding this comment.
We should probably use that across the entire hook and get rid of l1/l2 in params
| const isArbitrumTokenAndIsChildChainOrbit = | ||
| isArbitrumTokenList(listId) && isChildChainOrbit | ||
| const parentChainTokenAddress = isArbitrumTokenAndIsChildChainOrbit | ||
| ? tokenData.address.toLowerCase() |
There was a problem hiding this comment.
| ? tokenData.address.toLowerCase() | |
| ? address.toLowerCase() |
packages/arb-token-bridge-ui/src/components/TransferPanel/TokenRow.tsx
Outdated
Show resolved
Hide resolved
packages/arb-token-bridge-ui/src/components/TransferPanel/TokenRow.tsx
Outdated
Show resolved
Hide resolved
closes FS-327