Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow PHP 8.1 #763

Open
wants to merge 10 commits into
base: 2.15.x
Choose a base branch
from
Open

Allow PHP 8.1 #763

wants to merge 10 commits into from

Conversation

Fredthelead
Copy link

@Fredthelead Fredthelead commented Jul 11, 2022

  • Changed the PHP ~8.0.0 constraint to ~8.0
  • Ran composer update with composer 2.3.9 and PHP 8.0.21
  • Added PHP 8.1 to the github pipes
  • Updated psalm config and suppressed a false-positive

Fixes #721

@Ocramius Ocramius added this to the 2.15.0 milestone Jul 11, 2022
@Ocramius Ocramius self-assigned this Jul 11, 2022
psalm.xml Outdated Show resolved Hide resolved
psalm-baseline.xml Outdated Show resolved Hide resolved
psalm.xml Show resolved Hide resolved
@dfreudenberger
Copy link

Anything that needs to be done in order to get this merged & released? Happy to help if something is missing.

@Ocramius
Copy link
Owner

Release requires this work: https://github.com/Ocramius/ProxyManager/milestone/56

@Fredthelead
Copy link
Author

The problem with this PR is that the tests won't work with locked dependencies on both php 8.0 and 8.1. Not sure how to solve this without removing some tests.

@Ocramius
Copy link
Owner

Supporting 8.0 and 8.1 at the same time might indeed be challenging.

I can suggest skipping some tests on 8.0, so we focus on releasing a version that works on both PHP 8.0 and 8.1, then drop 8.0 support in a new minor, which in turn removes all conditionals that disable some tests.

@jakublabno
Copy link

Hi, any update on this?

@Ocramius
Copy link
Owner

#738 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add PHP 8.1 to CI pipeline
4 participants