Improve usage of phpunit #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malukenho
force-pushed
the
improve-test-suite
branch
from
70ba51d
to
fc4bfbb
Compare
Ocramius
requested changes
Feb 27, 2019
There was a problem hiding this comment.
@malukenho can you try bumping to PHPUnit 8.x too? Or is that too messy?
tests/ProxyManagerTest/Factory/LazyLoadingValueHolderFactoryTest.php
Outdated
Show resolved
Hide resolved
tests/ProxyManagerTest/Factory/AccessInterceptorScopeLocalizerFactoryTest.php
Outdated
Show resolved
Hide resolved
tests/ProxyManagerTest/Functional/AccessInterceptorValueHolderFunctionalTest.php
Outdated
Show resolved
Hide resolved
tests/ProxyManagerTest/ProxyGenerator/LazyLoadingValueHolder/MethodGenerator/MagicCloneTest.php
Outdated
Show resolved
Hide resolved
malukenho
force-pushed
the
improve-test-suite
branch
from
fc4bfbb
to
840a399
Compare
|
@malukenho one CS issue left, sorry ^_^'' |
malukenho
force-pushed
the
improve-test-suite
branch
from
840a399
to
3b47c1e
Compare
* Remove unnecessary assertions * Avoid using deprecated assertions (sebastianbergmann/phpunit#3338) * Add more entropy when needed * Use static methods whenever possible (providers, test cases that don't access object context) Signed-off-by: Jefersson Nathan <malukenho.dev@gmail.com>
malukenho
force-pushed
the
improve-test-suite
branch
from
3b47c1e
to
7fdd8ea
Compare
|
About the upgrade, I dunno how messy it is gonna be. But I'll try after this one is merged. |
👍 thanks, and please don't feel obliged to do so! |
Ocramius
approved these changes
Feb 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Deprecate assertions (and helper methods) that operate on (non-public) attributes sebastianbergmann/phpunit#3338)