Multitasking (Multi-Processing) [minor] #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsschult
approved these changes
Apr 28, 2023
| LOGGER.error("Task failed:") | ||
| LOGGER.error(_task_exception_str(task)) | ||
| else: | ||
| await sub.ack(tasks[task]) |
There was a problem hiding this comment.
Is there a reason why you use task.exception() instead of:
try:
await task
except Exception:
LOGGER.error("Task failed:")(note that this is also how you're supposed to get the return value from the future, if you had one)
There was a problem hiding this comment.
I believe I was following examples in the docs, which used the helper methods
There was a problem hiding this comment.
I'd be interested to know which docs?
This reverts commit c71cf1b.
This was referenced May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable multitasking, i.e. processing multiple tasks concurrently.
BREAKING CHANGE:
Users must now define the file type of the subprocess's input and output files. Previously, filepaths were defined. This change allows the files to be uniquely named. The user's
cmdargument can include meta-variables{{INFILE}}and{{OUTFILE}}which are replaced for the unique filename at runtime.closes #26