Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CPLHTTPFetch(): add a RETRY_CODES option, and C++'ify HTTP retry logic #9956

Merged
merged 2 commits into from
May 22, 2024
Merged

CPLHTTPFetch(): add a RETRY_CODES option, and C++'ify HTTP retry logic #9956

merged 2 commits into from
May 22, 2024

Conversation

rouault
Copy link
Member

@rouault rouault commented May 16, 2024

  • CPLHTTPFetch(): add a RETRY_CODES option (GDAL_HTTP_RETRY_CODES config option)

    Fixes GDAL_HTTP_RETRY_ALL Configuration option #9941

    -  .. config:: GDAL_HTTP_RETRY_CODES
      :choices: ALL or comma-separated list of codes
      :since: 3.10

      Specify which HTTP error codes should trigger a retry attempt.
      Valid values are ``ALL`` or a comma-separated list of HTTP codes.
      By default, 429, 500, 502, 503 or 504 HTTP errors are considered, as
      well as other situations with a particular HTTP or Curl error message.

  • Add C++ facilities for HTTP retry logic

@rouault
CPLHTTPFetch(): add a RETRY_CODES option (GDAL_HTTP_RETRY_CODES confi…
f66020b 
…g option)

Fixes OSGeo#9941

```
-  .. config:: GDAL_HTTP_RETRY_CODES
      :choices: ALL or comma-separated list of codes
      :since: 3.10

      Specify which HTTP error codes should trigger a retry attempt.
      Valid values are ``ALL`` or a comma-separated list of HTTP codes.
      By default, 429, 500, 502, 503 or 504 HTTP errors are considered, as
      well as other situations with a particular HTTP or Curl error message.
```
@rouault rouault added this to the 3.10.0 milestone May 16, 2024
@coveralls
Copy link
Collaborator

Coverage Status

coverage: 69.119% (+0.002%) from 69.117%
when pulling 48b5e18 on rouault:fix_9941
into c31cbe0 on OSGeo:master.

elpaso
elpaso approved these changes May 22, 2024
View reviewed changes
port/cpl_http.h Show resolved Hide resolved
port/cpl_http.cpp Show resolved Hide resolved
@rouault rouault merged commit 77031d7 into OSGeo:master May 22, 2024
32 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elpaso elpaso elpaso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.10.0
Development

Successfully merging this pull request may close these issues.

GDAL_HTTP_RETRY_ALL Configuration option
3 participants
@rouault @coveralls @elpaso