Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to the active sessions widget after the introduction of the Turbo Stream libraries #3546

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

abujeda
Copy link
Contributor

@abujeda abujeda commented May 9, 2024

The Active Sessions widget is meant to display a subset of the current active interactive sessions.

After the introduction of the Turbo Stream, all the session cards (regardless of the status) are replaced when an update is fetch from the server. This is causing that the active sessions widget goes from showing the first 3 active sessions to display all.

The fix is simply to disable the updates.
Later on, we will implement a solution to refresh the session data in the widget.

@johrstrom
Copy link
Contributor

Later on, we will implement a solution to refresh the session data in the widget.

How big of a change is that? You may want to go ahead and see because I'm preparing for Summer Institute which is eating a lot of my time/focus. Which is to say - I may not get to this quickly.

@abujeda
Copy link
Contributor Author

abujeda commented May 13, 2024

I think it could be a medium size change. At the moment we are focusing on a deployment and an upgrade to 3.1 so it will be a while until I pick this issue again. I just want to have a fix in place in case it makes it into a release

@johrstrom
Copy link
Contributor

I see - turbo stuff (and rails upgrade to 7) won't come until 4.0. so none of this will be in the 3.1.x releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants