initial pass to make projects#show dynamic #3534
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johrstrom
commented
Apr 26, 2024
apps/dashboard/config/routes.rb
Outdated
| get '/jobs/info/:cluster/:id' => 'jobs#info', :defaults => { :format => 'json' }, :as => 'jobs_info' | ||
| get '/jobs/info/:cluster/:id' => 'jobs#pm_job_details', :defaults => { :format => 'turbo_stream' }, :as => 'pm_job_details' |
There was a problem hiding this comment.
I named this route jobs#pm_job_details just because I don't know if these partials are going to be useful for other pages. So we may as well make the API specific for the project manager.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial pass to make
projects#showpage dynamic.It changes the jobs controller a bit to return a turbo stream partial that the
projects#showcan then display.It's an initial pass in the sense that the partials being returned a super simple. I just wanted to create a PR that was basically as small as it could be.