simple refactor of turbo shim #3514
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johrstrom
commented
Apr 17, 2024
Oglopf
reviewed
Apr 26, 2024
| .then((html) => replaceHTML(id, html)) | ||
| .then(setTimeout(pollAndReplace, delay, url, delay, id)) | ||
| .catch((err) => { | ||
| console.log('Cannot not retrive partial due to error:'); |
There was a problem hiding this comment.
This all looks good, but it's early, and I swear this is reading as a double negative (but I'm brewing my coffee still). Should this just be Cannot retrieve partial due to error: or am I still waking up?
There was a problem hiding this comment.
Lol yea, that's a double negative. I'll update now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple refactor of turbo_shim.js to promote reuse because basically every component is going to poll as well as replace.