Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Black + Click Version Controlling #179

Merged
merged 1 commit into from
Jun 14, 2023
Merged

Conversation

JustinBakerMath
Copy link
Collaborator

This PR aims to resolve the first issue described in PR #178 (comment) by pinning the click version in the setup of pre-commit.

I tested manually installing black==21.5b1 and click==8.0.0 as illustrated below, but encountered the same compatibility issue.

ClickBlackVersions

These compatibility issues are resolved using the additional_dependencies argument. Notice: I used click==8.0.0 consistent with the version in https://github.com/ORNL/HydraGNN/blob/main/requirements.txt

@JustinBakerMath JustinBakerMath self-assigned this Jun 13, 2023
@JustinBakerMath JustinBakerMath added the bug Something isn't working label Jun 13, 2023
@JustinBakerMath JustinBakerMath marked this pull request as ready for review June 14, 2023 03:15
@allaffa allaffa merged commit 26ed8b8 into ORNL:main Jun 14, 2023
2 checks passed
@JustinBakerMath JustinBakerMath deleted the vc-click-black branch June 17, 2023 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants