Unit tests #67
Unit tests #67
Conversation
Codecov Report
@@ Coverage Diff @@
## master #67 +/- ##
==========================================
+ Coverage 11.4% 12.71% +1.31%
==========================================
Files 154 154
Lines 4426 4434 +8
Branches 908 910 +2
==========================================
+ Hits 505 564 +59
+ Misses 3099 3060 -39
+ Partials 822 810 -12
Continue to review full report at Codecov.
|
| beforeEach(() => { | ||
| Math.random = jest.fn(() => 0.4677647565236618); | ||
| }); | ||
| Math.random = jest.fn(() => 0.4677647565236618); |
There was a problem hiding this comment.
Will this bleed into a different test suite? Do you need to "undo" this patch after all of these tests have run?
There was a problem hiding this comment.
Good point. It won't right now but it is safe to add a clearAllMocks
There was a problem hiding this comment.
@biharck, if you use Math.random somewhere else, I think it would still be a jest.fn? Doesn't clearAllMocks just reset the function so you can see what args are passed?
I think you need to do something like...
const savedFn = Math.random;
Math.random = jest.fn();
// after all
Math.random = savedFn;
There was a problem hiding this comment.
For example: jestjs/jest#7136 (comment)
But I think you're right that Math.random calls in other test suites would use the baked in implementation, and not the one we override here.
|
🎉 This PR is included in version 0.11.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
No description provided.