New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update black rev in order to include fix for https://github.com/psf/black/issues/1629 #92
Conversation
.pre-commit-config.yaml
Outdated
@@ -1,6 +1,6 @@ | |||
repos: | |||
- repo: https://github.com/psf/black | |||
rev: 19.10b0 | |||
rev: 21.4b0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the repo's config. I guess you want to change this instead https://github.com/OCA/oca-addons-repo-template/blob/master/src/.pre-commit-config.yaml.jinja#L4 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, thanks for the advice @simahawk!
c3dcf2e
to
4c60c1a
Compare
4c60c1a
to
d14b54e
Compare
@@ -3,7 +3,7 @@ | |||
|
|||
{%- if odoo_version < 15 %} | |||
{%- set repo_rev.autoflake = "v1.4" %} | |||
{%- set repo_rev.black = "20.8b1" %} | |||
{%- set repo_rev.black = "21.4b0" %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem with changing black on active branches is that it creates some churn with PRs becoming red due to minor reformating. That said, black is getting more and more stable over time. Alternatives:
|
Ok, thanks for the explanation. Personally I'd prefer the following:
|
I ran into this error related to psf/black#1629.
In order to fix it, black needs to be updated at least to https://pypi.org/project/black/21.4b0.