Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] oca-towncrier: Add support for Mardown format #607

Merged
merged 1 commit into from
Mar 17, 2024

Conversation

lmignon
Copy link
Sponsor Contributor

@lmignon lmignon commented Mar 1, 2024

If readme fragments uses the md format, generates the history file into the same format

This should fix the issue preventing the merge of some PR as OCA/search-engine#176 (comment)

@lmignon lmignon force-pushed the master-fix-towncrier-md branch 5 times, most recently from 25edf51 to 9f4ee02 Compare March 1, 2024 15:57
@ivs-cetmix
Copy link
Member

@lmignon thank you for this PR! We have exactly the same issue in our local repos after wi switched to .md format and were looking for solution.

Copy link
Member

@ivs-cetmix ivs-cetmix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deployed and tested on our internal OCA bot instance.
Functional review LGTM

@lmignon lmignon force-pushed the master-fix-towncrier-md branch 2 times, most recently from 2f6d945 to e54c0dc Compare March 11, 2024 11:08
If readme fragments uses the md format, generate the history file into the same format
@lmignon
Copy link
Sponsor Contributor Author

lmignon commented Mar 11, 2024

ping @sbidoul

@sbidoul sbidoul merged commit d0c8b4d into OCA:master Mar 17, 2024
6 checks passed
@sbidoul sbidoul deleted the master-fix-towncrier-md branch March 17, 2024 18:30
@sbidoul
Copy link
Member

sbidoul commented Mar 17, 2024

Thank you. This is deployed on the OCA github bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants