-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for 1.0 #39
Prepare for 1.0 #39
Conversation
Seems fine to me. It has been stable to a while now. Wondering if we want to clear the other 2 PRs before pushing 1.0? |
I have just rebased #27 on the latest master. It introduces a minor parameter widening on the methods ( |
PR is rebased and the BC break is documented |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made another small change to this PR. What do you think? |
Aah, I must have missed that one. If I read this correctly, this is to allow the user to pass in |
Thank you |
This will fix #11
This package has been fairly stable for a long while.