Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for 1.0 #39

Merged
merged 3 commits into from
Jun 6, 2020
Merged

Prepare for 1.0 #39

merged 3 commits into from
Jun 6, 2020

Conversation

Nyholm
Copy link
Owner

@Nyholm Nyholm commented Jun 6, 2020

This will fix #11

This package has been fairly stable for a long while.

@Nyholm Nyholm requested a review from Zegnat June 6, 2020 10:35
@Zegnat
Copy link
Collaborator

Zegnat commented Jun 6, 2020

Seems fine to me. It has been stable to a while now. Wondering if we want to clear the other 2 PRs before pushing 1.0?

@Zegnat
Copy link
Collaborator

Zegnat commented Jun 6, 2020

I have just rebased #27 on the latest master. It introduces a minor parameter widening on the methods ($post goes from array to array|null). Would love to be able to land that before version 1.0. As I think it is the only thing (from both PRs and issues) that actually signifies a method signature change.

@Nyholm
Copy link
Owner Author

Nyholm commented Jun 6, 2020

PR is rebased and the BC break is documented

Copy link
Collaborator

@Zegnat Zegnat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think I have time to look at #34 today, which is the final PR left on the list. That one should not cause any further API changes however, so I think we can tag 1.0 whenever suits now that #27 is in! 🚀

@Nyholm
Copy link
Owner Author

Nyholm commented Jun 6, 2020

I made another small change to this PR. What do you think?

@Zegnat
Copy link
Collaborator

Zegnat commented Jun 6, 2020

Aah, I must have missed that one. If I read this correctly, this is to allow the user to pass in null when they want to specify $files and $body? Makes a lot of sense to me!

@Nyholm
Copy link
Owner Author

Nyholm commented Jun 6, 2020

Thank you

@Nyholm Nyholm merged commit 8625299 into master Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version 1.0?
2 participants