Add definitions for aarch64 apple OSX. #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I got these by running the provided scripts/codegen.sh, with CODEGEN64 removed. They seem to match up with the contents of the resource.h from the SDK. With these defintions, rlimit now builds and passes its tests on my M1 laptop. Closes issue Nugine#35.
|
(Also, I wasn't sure whether to target this MR at dev or at master; please edit as appropriate.) |
|
The custom codegen accidentally breaks compilation on M1. Thanks for the fix. Now the cross test workflow automatically generates bindings.rs and check whether it matches the one in src. But GitHub action doesn't support M1 yet (actions/runner#805). It seems that the codegen check must emit a warning instead of an error. I will change it later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got these by running the provided scripts/codegen.sh, with
CODEGEN64 removed. They seem to match up with the contents of the
resource.h from the SDK. With these definitions, rlimit now builds
and passes its tests on my M1 laptop.
Closes issue #35.
Please let me know if I've messed anything up here: I chose the name by analogy with other module names in bindings.rs