Embed NuGet files in binlog after restore #5042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
donnie-msft
reviewed
Feb 7, 2023
test/NuGet.Core.Tests/NuGet.Build.Tasks.Test/TaskLoggingQueueTests.cs
Outdated
Show resolved
Hide resolved
nkolev92
reviewed
Feb 8, 2023
src/NuGet.Core/NuGet.Build.Tasks.Console/MSBuildStaticGraphRestore.cs
Outdated
Show resolved
Hide resolved
src/NuGet.Core/NuGet.Build.Tasks.Console/MSBuildStaticGraphRestore.cs
Outdated
Show resolved
Hide resolved
jeffkl
force-pushed
the
dev-jeffkl-embed-nuget-files-in-binlog
branch
from
0936da1
to
93f8eb4
Compare
aortiz-msft
reviewed
Feb 11, 2023
zivkan
reviewed
Feb 13, 2023
src/NuGet.Core/NuGet.Build.Tasks.Console/MSBuildStaticGraphRestore.cs
Outdated
Show resolved
Hide resolved
nkolev92
previously approved these changes
Feb 21, 2023
zivkan
previously approved these changes
Feb 22, 2023
donnie-msft
reviewed
Feb 22, 2023
test/NuGet.Core.Tests/NuGet.Build.Tasks.Console.Test/BuildTasksUtilityTests.cs
Outdated
Show resolved
Hide resolved
jeffkl
force-pushed
the
dev-jeffkl-embed-nuget-files-in-binlog
branch
from
8206cce
to
f8bd8a9
Compare
donnie-msft
approved these changes
Feb 22, 2023
zivkan
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#12374
Regression? No Last working version:
Description
This is a follow-up of #5016 but now it includes the files from all projects that took part in restore.
This updates the Restore task to embed NuGet files in the binlog after Restore is complete. Even if restore fails, any files that exist will be embedded:
In this case the package name is wrong and the
.dgspecis still in the binlog.For static graph-based restore, the output paths are logged back to the RestoreTaskEx so it can embed the files in the binlog at the end of the actual build. I could not find a way to embed them in the
nuget.binlogthat contains evaluation...Related to dotnet/sdk#16840
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation