feat: center course navbar when the screen is wider #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uier
reviewed
Mar 17, 2024
src/components/CourseSideBar.vue
Outdated
| @@ -47,7 +47,7 @@ const navs = [ | |||
| </li> | |||
| </ul> | |||
| <div v-else class="scrollbar-hide w-full overflow-scroll"> | |||
| <div class="tabs w-max"> | |||
| <div class="tabs m-auto w-max"> | |||
There was a problem hiding this comment.
updated. I just didn't think much about it
laporchen
force-pushed
the
feat/center-course-nav-bar
branch
from
82b5387
to
b2ea79f
Compare
Deploying nfe with
|
| Latest commit: |
b2ea79f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://80452167.nfe.pages.dev |
| Branch Preview URL: | https://feat-center-course-nav-bar.nfe.pages.dev |
uier
approved these changes
Mar 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On #159, the menu bar was redesigned for smaller screen.
But it doesn't look that good on in-between screen size.
Made navbar centered to make it looks a bit nicer.