LLT-5040 Fix nat-lab issues around dockers #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjanowsk
requested review from
a team,
Jauler,
packgron and
tomaszklak
as code owners
jjanowsk
changed the title
arg0d
reviewed
Apr 5, 2024
jjanowsk
force-pushed
the
LLT-5040-docker-compose-update
branch
from
b552195
to
ed39c2a
Compare
tomaszklak
requested changes
Apr 5, 2024
moby/moby#47619 Because of this bug eth0 is not created before sysctl are being set so it is not possible to set any syscts related to the specific interfaces. We can create a workaround by not setting eth0. Instead we can set default so eth0 will have this value assigned later when created.
This reverts commit b98310a. The bug with missing interfaces was not related to any race condition. It was a bug in docker compose: docker/compose#11510 The only affected version is: 2.24.6
v1.0.2 uses Vagrant box with updated docker compose version to get rid of nat-lab issues with missing network interfaces
jjanowsk
force-pushed
the
LLT-5040-docker-compose-update
branch
from
ed39c2a
to
048c05c
Compare
packgron
pushed a commit
that referenced
this pull request
Jun 4, 2024
LLT-5040 Fix nat-lab issues around dockers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug no. 1: Bug in docker compose: docker/compose#11510
This bug randomly causes missing network interfaces in started containers. We just updated docker compose version to the version which is not affected.
Bug no. 2: Bug in docker daemon: moby/moby#47619
Because of this bug eth0 is not created before sysctls are being set so it is not possible to set any sysctls related to the specific interfaces.
We can create a workaround by not setting eth0. Instead we can set default so eth0 will have this value assigned later when created.
☑️ Definition of Done checklist