feat: check check constructor args type

[fwx5618177]

• Because this PR includes a bug fix, relevant tests have been included.
• Because this PR includes a new feature, the change was previously discussed on an Issue or with someone from the team.
• I didn't do anything of this.

---

1. Added detection of parameters when passing arguments to the constructor. Currently, the detection is done on the backend, which makes it difficult to distinguish between strings and numbers in the tool. Therefore, a new feature has been submitted to address this issue.

This is the contract code:

// SPDX-License-Identifier: MIT
pragma solidity ^0.8.20;

contract MyContract {

    string public url;
    uint256 public add;

    constructor(string memory _url, uint256 _add) {
        url = _url;
        add = _add;
    }

    function setUrl(string memory _url) public {
        url = _url;
    }
}

Parameter passing file:

module.exports = [
    123,
    123
];

Using the command:

npx hardhat verify --contract contracts/MyToken.sol:MyContract [ADDRESS] --constructor-args scripts/arguments.js

[changeset-bot]

🦋 Changeset detected

Latest commit: cb2ad86

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@nomicfoundation/hardhat-verify	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
hardhat	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 15, 2024 1:27am

[fwx5618177]

@kanej Maybe this pr not feature, it's fix?

[schaable]

This is a nice check when the constructor arguments are provided via a file or when the task is called programmatically. However, it doesn't have any effect when the arguments are passed through the CLI, as they are interpreted as strings. I've cleaned up the code, added a test, and included the changeset.

[fwx5618177]

This is a nice check when the constructor arguments are provided via a file or when the task is called programmatically. However, it doesn't have any effect when the arguments are passed through the CLI, as they are interpreted as strings. I've cleaned up the code, added a test, and included the changeset.

Got it. Maybe We need to transform string to a number and check if it's NaN or not.

[schaable]

Got it. Maybe We need to transform string to a number and check if it's NaN or not.

I don't think we need to, as the verification succeeds anyway.