Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make solcjs compilation work when Hardhat is bundled #3406

Merged
merged 2 commits into from Dec 8, 2022
Merged

Make solcjs compilation work when Hardhat is bundled #3406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
968a58f
Make solcjs compilation work when Hardhat is bundled
fvictorio Dec 8, 2022
7154371
Create orange-jobs-hug.md
fvictorio Dec 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/orange-jobs-hug.md
View file
Open in desktop
@@ -0,0 +1,5 @@
---
"hardhat": patch
---

Fixed an issue that caused compilation with solcjs to not work when Hardhat is bundled
8 changes: 8 additions & 0 deletions packages/hardhat-core/src/internal/solidity/compiler/index.ts
View file
Open in desktop
Expand Up @@ -41,6 +41,14 @@ export class Compiler implements ICompiler {
*/
private _loadCompilerSources(compilerPath: string) {
const Module = module.constructor as any;

// if Hardhat is bundled (for example, in the vscode extension), then
// Module._extenions might be undefined. In that case, we just use a plain
// require.
if (Module._extensions === undefined) {
return require(compilerPath);
}

const previousHook = Module._extensions[".js"];

Module._extensions[".js"] = function (
Expand Down