Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed proxyContextEs5 name to proxylessContext, fixed addRuleSet bug #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ev-akarel
Copy link

@ev-akarel ev-akarel commented Aug 4, 2020

Description

Fixed addRuleSet method so that it returns the context object correctly.

Fixes bug in PR #171 which fixes issue #45.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please, feel free to specify what kind of change it is)

Checklist:

  • I have created my branch from a recent version of master
  • The code is clean and easy to understand
  • I have written tests to guarantee that everything is working properly
    • I have, but out of scope for this project, since they needed to be in an environment without a Proxy object.
  • I have made corresponding changes to the documentation
  • I have added changes to the Unreleased section of the CHANGELOG

@ev-akarel
Copy link
Author

@NoemiRozpara This is to address the issue discussed in your v8n PR #171. The addRuleSet method was just not returning anything, which was causing the error. I also updated the changelog and docs, so your PR should be good to go once this gets merged in. Let me know if you have any questions.

@taiga533
Copy link

@ev-akarel
Hi.
I think this pull request should be reworked into a pull request from your repository to imbrn/v8n.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants