Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python packages set updates #83676

Merged
merged 20 commits into from Apr 27, 2020
Merged

Python packages set updates #83676

merged 20 commits into from Apr 27, 2020

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Mar 29, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@KamilaBorowska
Copy link
Member

KamilaBorowska commented Mar 29, 2020

This won't work due to pytest-dev/pytest-asyncio#141 :(. There is a patch for this issue on pytest-dev/pytest-asyncio#142, but it's incompatible with older versions.

@FRidh
Copy link
Member Author

FRidh commented Mar 29, 2020

We'll likely need to wait another month or so with the pytest bump because its still very fresh.

@FRidh FRidh merged commit 4ffb40b into staging Apr 27, 2020
Staging automation moved this from WIP to Done Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Staging
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants