Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 0.2024.05.07.08.02.stable_02 #310969

Closed
wants to merge 3 commits into from
Closed

Conversation

soggywhale
Copy link

@soggywhale soggywhale commented May 12, 2024

Description of changes

2024.05.09 (v0.2024.05.07.08.02)

Bug fixes

  • Vim-related settings no longer appear in the Command Palette when editing with Vim keybindings is disabled

  • Warp's Input Editor now immediately reflects any changes to the Vim status bar settings

  • Fixed a bug when handling URLs with parentheses in notebooks and Warp AI

Things done

changed the version.json for the linux version, I havent tested on the darwin version for MacOS.

I build it with nix-build -A warp-terminal and it worked on my machine. NixOS btw

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

Copy link
Member

@AndersonTorres AndersonTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reword the commits according to the contribution guidelines.

@ghost
Copy link

ghost commented May 12, 2024

duplicate of #308877

also note that the darwin version was updated and not the hash. to update, should use the update script:

nix-shell -I nixpkgs=. maintainers/scripts/update.nix --argstr path warp-terminal

@soggywhale
Copy link
Author

Reword the commits according to the contribution guidelines.

I just read the guidelines and before I make other commits can you please elaborate on what can be improved on my commits ? do I need to be more precise ?

@DontEatOreo
Copy link
Member

I just read the guidelines and before I make other commits can you please elaborate on what can be improved on my commits ? do I need to be more precise ?

Please read this specific section here as well: https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#commit-conventions

(pkg-name): (from -> to | init at version | refactor | etc)

(Motivation for change. Link to release notes. Additional information.)

In your case, you should have had one commit, and it should have been named: warp-terminal: 0.2024.04.16.08.02.stable_00 -> 0.2024.05.07.08.02.stable_02

Since #308877 has already been merged, I will close this PR, wishing you luck on future PR's!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants