Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vbam: Fix gsettings problems. #310963

Merged
merged 1 commit into from May 12, 2024
Merged

vbam: Fix gsettings problems. #310963

merged 1 commit into from May 12, 2024

Conversation

Noodlez1232
Copy link
Contributor

@Noodlez1232 Noodlez1232 commented May 12, 2024

Description of changes

Solution inspired by #305611. If VBAm was used on a system without any gsettings schemas (common on non-GNOME installs), trying to do any sort of opening of directories or other things that require those schemas would cause a hang-then-crash situation.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Noodlez1232
Copy link
Contributor Author

Forgot to tag maintainers: @Lassulus @NetaliDev

Solution inspired by NixOS#305611. If VBAm was used on a system without any
gsettings schemas (common on non-GNOME installs), trying to do any sort
of opening of directories or other things that require those schemas
would cause a hang-then-crash situation.
@ofborg ofborg bot requested review from NetaliDev and Lassulus May 12, 2024 03:42
@Lassulus Lassulus merged commit 48ca937 into NixOS:master May 12, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants