Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

glance: init at 0.3.0 #310955

Merged
merged 2 commits into from May 12, 2024
Merged

glance: init at 0.3.0 #310955

merged 2 commits into from May 12, 2024

Conversation

dvn0
Copy link
Contributor

@dvn0 dvn0 commented May 11, 2024

Description of changes

Adds Glance

A self-hosted dashboard that puts all your feeds in one place

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
pkgs/by-name/gl/glance/package.nix Show resolved Hide resolved
pkgs/by-name/gl/glance/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/gl/glance/package.nix Outdated Show resolved Hide resolved
@marcusramberg
Copy link
Contributor

[nix-shell:~/.cache/nixpkgs-review/pr-310955]$ ls results/glance/bin/
build-and-ship  glance

build-and-ship probably doesn't need to be included in the package?

@dvn0
Copy link
Contributor Author

dvn0 commented May 12, 2024

build-and-ship probably doesn't need to be included in the package?

good catch

@dvn0
Copy link
Contributor Author

dvn0 commented May 12, 2024

build-and-ship probably doesn't need to be included in the package?

Okay fixed here bdde1ad

Copy link
Contributor

@marcusramberg marcusramberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@marcusramberg marcusramberg merged commit 7a94f13 into NixOS:master May 12, 2024
23 of 25 checks passed
@dvn0 dvn0 deleted the dvn0/glance-init branch May 12, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants