Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tinymist: 0.11.6 -> 1.11.8 #310944

Merged
merged 2 commits into from May 12, 2024
Merged

tinymist: 0.11.6 -> 1.11.8 #310944

merged 2 commits into from May 12, 2024

Conversation

GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented May 11, 2024 •
edited

Description of changes

Changelog: https://github.com/Myriad-Dreamin/tinymist/blob/v0.11.8/CHANGELOG.md

cc @LamprosPitsillos @drupol

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 310944 run on x86_64-linux 1

2 packages built:
  • tinymist
  • vscode-extensions.myriad-dreamin.tinymist

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 310944 run on aarch64-linux 1

2 packages built:
  • tinymist
  • vscode-extensions.myriad-dreamin.tinymist

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 310944 run on aarch64-darwin 1

2 packages built:
  • tinymist
  • vscode-extensions.myriad-dreamin.tinymist

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 310944 run on x86_64-darwin 1

2 packages built:
  • tinymist
  • vscode-extensions.myriad-dreamin.tinymist

marcusramberg
marcusramberg approved these changes May 12, 2024
View reviewed changes
Copy link
Contributor

@marcusramberg marcusramberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

[nix-shell:~/.cache/nixpkgs-review/pr-310944]$ ./results/tinymist/bin/tinymist -V
tinymist 0.11.8

@marcusramberg marcusramberg merged commit 56c19df into NixOS:master May 12, 2024
36 of 40 checks passed
@GaetanLepage GaetanLepage deleted the tinymist branch May 12, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcusramberg marcusramberg marcusramberg approved these changes

@drupol drupol drupol approved these changes

@LamprosPitsillos LamprosPitsillos Awaiting requested review from LamprosPitsillos

Assignees
No one assigned
Labels
6.topic: vscode 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@GaetanLepage @marcusramberg @drupol