xairedit: init at 1.8.1 #310943
xairedit: init at 1.8.1 #310943
Conversation
| @@ -35613,6 +35613,8 @@ with pkgs; | |||
|
|
|||
| x42-plugins = callPackage ../applications/audio/x42-plugins { }; | |||
|
|
|||
| xairedit = callPackage ../applications/audio/midas/xairedit.nix { }; | |||
There was a problem hiding this comment.
Ideally all new top-level packages should be using the new by-name scheme — maybe you can migrate all the other ones while you're at it?
There was a problem hiding this comment.
How would I move this to the by-name architecture? Considering this is using a helper function to generate multiple packages with different names (x32mixer, m32mixer, xairmixer) and as far as I understood the by-name architecture you're only supposed to use files from that package's directory (or you can't use files outside that directory)?
| installPhase = '' | ||
| runHook preInstall |
There was a problem hiding this comment.
Good catch — that should've always been in there 😅
|
|
||
| desktopItems = [ | ||
| (makeDesktopItem { | ||
| name = "${pname}"; |
There was a problem hiding this comment.
I'm not sure how I feel about this. Firstly, the quotes and the braces are completely unnecessary as you can just use pname directly, but I don't think using pname is a good idea at all — theoretically someone can just override pname and ruin everything.
Given this is a 'generic' version of a bunch of different packages, maybe you could accept differently-named parameters that are hard to accidentally override?
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)libcurl.so.4: no version information available, any idea on how to fix this?Add a 👍 reaction to pull requests you find important.