age: skip flaky plugin test #265753
Merged
age: skip flaky plugin test #265753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately this test also fails on Linux sometimes, not just Darwin... |
ghost
reviewed
Nov 6, 2023
pkgs/tools/security/age/default.nix
Outdated
Comment on lines
57
to
59
| preCheck = lib.optionalString stdenv.isDarwin '' | ||
| buildFlagsArray+=("-skip" "TestScript/plugin") | ||
| ''; |
There was a problem hiding this comment.
Suggested change
| preCheck = lib.optionalString stdenv.isDarwin '' | |
| buildFlagsArray+=("-skip" "TestScript/plugin") | |
| ''; | |
| checkFlags = lib.optionals stdenv.isDarwin [ | |
| "-skip" "TestScript/plugin" | |
| ]; |
i think using checkFlags here works.
See issue in upstream FiloSottile/age#517. age sometimes fails this test, but sometimes it doesn't. Disable this test until the upstream issue is resolved.
YorikSar
force-pushed
the
age-disable-flaky-test
branch
from
88bf64b
to
2e5986a
Compare
|
@someplaceguy @robert-manchester Good points, thanks. Updated to unconditionally skip with checkFlags. |
ghost
approved these changes
Nov 6, 2023
|
I also approve. |
|
Sounds reasonable! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
See issue in upstream FiloSottile/age#517.
age fails this test on both
x86_64andaarch64, but sometimes it doesn't.Disable this test until the upstream issue is resolved.
CC @someplaceguy and @ctheune who've been active in the upstream issue
ZHF: #265948
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)