Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koodo-reader: init at 1.6.6 #259840

Merged
merged 1 commit into from
Apr 22, 2024
Merged

koodo-reader: init at 1.6.6 #259840

merged 1 commit into from
Apr 22, 2024

Conversation

TomaSajt
Copy link
Contributor

@TomaSajt TomaSajt commented Oct 8, 2023

Description of changes

Closes #259589

This PR adds 1 package: koodo-reader

This is an Electron app.

There is a patch which bumps a node dependency version
(This was the encountered issue: i18next/react-i18next#1543)

There's another patch which just hard-codes isDev to false, as electron-is-dev wasn't working.

The package provides MIME types. When packaging as .deb, electron-builder would generate an .xml file listing them, and would create a .desktop file supporting them.
I couldn't find a way to generate these when building as an .asar file, so I copied the .xml file from the .deb release. I also manually set the desktopItem's mimeTypes attribute.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@pbsds pbsds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

error: hash mismatch in fixed-output derivation '/nix/store/a6vbmxxs9c922mxcjgpyvb8ymdw4dgcv-source.drv':
         specified: sha256-SScbK3pJRqMQ14vj2z4Ek5eSfGxbWN5TYIWLFKRofFk=
            got:    sha256-qDLacMRsr8XHvPBX8gGLXuN1R2fzyf2jMvRt+ilgrk0=

pkgs/by-name/ko/koodo-reader/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ko/koodo-reader/package.nix Outdated Show resolved Hide resolved
@TomaSajt TomaSajt closed this Apr 21, 2024
@TomaSajt TomaSajt reopened this Apr 21, 2024
@TomaSajt TomaSajt changed the title koodo-reader: init at 1.5.9 koodo-reader: init at 1.6.6 Apr 21, 2024
@pbsds
Copy link
Contributor

pbsds commented Apr 21, 2024

$ nix-env --extra-experimental-features no-url-literals --option system x86_64-linux -f /home/pbsds/.cache/nixpkgs-review/pr-259840-2/nixpkgs -qaP --xml --out-path --show-trace --no-allow-import-from-derivation --meta
error:
       … while querying the derivation named 'koodo-reader-1.6.6'
...
       error: attribute 'rev' missing

       at /home/pbsds/.cache/nixpkgs-review/pr-259840-2/nixpkgs/pkgs/by-name/ko/koodo-reader/package.nix:118:74:

          117|     broken = stdenv.isDarwin;
          118|     changelog = "https://github.com/troyeguo/koodo-reader/releases/tag/${src.rev}";
             |                                                                          ^
          119|     description = "A cross-platform ebook reader";

@TomaSajt
Copy link
Contributor Author

$ nix-env --extra-experimental-features no-url-literals --option system x86_64-linux -f /home/pbsds/.cache/nixpkgs-review/pr-259840-2/nixpkgs -qaP --xml --out-path --show-trace --no-allow-import-from-derivation --meta
error:
       … while querying the derivation named 'koodo-reader-1.6.6'
...
       error: attribute 'rev' missing

       at /home/pbsds/.cache/nixpkgs-review/pr-259840-2/nixpkgs/pkgs/by-name/ko/koodo-reader/package.nix:118:74:

          117|     broken = stdenv.isDarwin;
          118|     changelog = "https://github.com/troyeguo/koodo-reader/releases/tag/${src.rev}";
             |                                                                          ^
          119|     description = "A cross-platform ebook reader";

Oh, I forgot that I was using applyPatches, should be fine now.

Copy link
Contributor

@pbsds pbsds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 259840 run on x86_64-linux 1

1 package built:
  • koodo-reader

took a while to build electron, but it runs fine, LGTM!

@pbsds pbsds merged commit 66f5baa into NixOS:master Apr 22, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: Koodo Reader
2 participants