-
-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koodo-reader: init at 1.6.6 #259840
koodo-reader: init at 1.6.6 #259840
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
error: hash mismatch in fixed-output derivation '/nix/store/a6vbmxxs9c922mxcjgpyvb8ymdw4dgcv-source.drv':
specified: sha256-SScbK3pJRqMQ14vj2z4Ek5eSfGxbWN5TYIWLFKRofFk=
got: sha256-qDLacMRsr8XHvPBX8gGLXuN1R2fzyf2jMvRt+ilgrk0=
|
Oh, I forgot that I was using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Result of nixpkgs-review pr 259840
run on x86_64-linux 1
1 package built:
- koodo-reader
took a while to build electron, but it runs fine, LGTM!
Description of changes
Closes #259589
This PR adds 1 package:
koodo-reader
This is an Electron app.
There is a patch which bumps a node dependency version
(This was the encountered issue: i18next/react-i18next#1543)
There's another patch which just hard-codes
isDev
to false, aselectron-is-dev
wasn't working.The package provides MIME types. When packaging as
.deb
,electron-builder
would generate an.xml
file listing them, and would create a.desktop
file supporting them.I couldn't find a way to generate these when building as an
.asar
file, so I copied the.xml
file from the.deb
release. I also manually set thedesktopItem
'smimeTypes
attribute.Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)