Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/k3s: start after network-online.target #223823

Merged
merged 1 commit into from Mar 30, 2023
Merged

nixos/k3s: start after network-online.target #223823

merged 1 commit into from Mar 30, 2023

Conversation

superherointj
Copy link
Contributor

@superherointj superherointj commented Mar 30, 2023

nixos/k3s: start after network-online.target

Fixes #103158

Wants network.service does not exist:

image

Thought of network.target. But Arch Wiki says it is not necessary:

image

Will remove wants = [ "network.target" ] then.

@Scrumplex Scrumplex self-requested a review March 30, 2023 10:03
@Scrumplex
Copy link
Member

Can this be backported to 22.11 as well?

@superherointj
Copy link
Contributor Author

Can this be backported to 22.11 as well?

Just add the tag and follow up on it...

Copy link
Contributor

@jian-lin jian-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@superherointj superherointj merged commit b7fc729 into NixOS:master Mar 30, 2023
5 checks passed
@superherointj superherointj deleted the k3s-startup-after-network branch March 30, 2023 13:17
@github-actions
Copy link
Contributor

Successfully created backport PR for release-22.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

k3s: Service starts up before network; and doesn't shutdown properly
4 participants