Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.autopep8: patch for pycodestyle-2.10.0 #205803

Merged
merged 1 commit into from Dec 13, 2022

Conversation

lilyinstarlight
Copy link
Member

@lilyinstarlight lilyinstarlight commented Dec 12, 2022

Description of changes

This adjusts autopep8 to fetch from GitHub so it can be patched (patch does not apply cleanly to PyPI source tarball), and a test that had to be disabled because it was fetched from PyPI is re-enabled since it could work now (and as far as I understand, pulling from git is generally preferred for Python packages in nixpkgs for test reasons)

This lets the package now build successfully with the recent pycodestyle 2.10.0 bump in #203378

Closes #205733

Ref hhatto/autopep8#659 and hhatto/autopep8#661

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.
nixpkgs-review

Result of nixpkgs-review pr 205803 run on x86_64-linux 1

20 packages built:
  • cmake-format
  • cmake-language-server
  • python310Packages.autopep8
  • python310Packages.django_silk
  • python310Packages.pyls-flake8
  • python310Packages.pyls-isort
  • python310Packages.pyls-spyder
  • python310Packages.pylsp-mypy
  • python310Packages.python-lsp-black
  • python310Packages.python-lsp-server
  • spyder (python310Packages.spyder)
  • python39Packages.autopep8
  • python39Packages.django_silk
  • python39Packages.pyls-flake8
  • python39Packages.pyls-isort
  • python39Packages.pyls-spyder
  • python39Packages.pylsp-mypy
  • python39Packages.python-lsp-black
  • python39Packages.python-lsp-server
  • python39Packages.spyder

Copy link
Contributor

@bjornfor bjornfor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! But please put the PR description in the commit message, so the reasoning behind the change is stored in git.

Copy link
Contributor

@bjornfor bjornfor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: please end sentences in commit message with a dot.

This adjusts autopep8 to fetch from GitHub so it can be patched (patch does not
apply cleanly to PyPI source tarball), and a test that had to be disabled
because it was fetched from PyPI is re-enabled since it could work now (and as
far as I understand, pulling from git is generally preferred for Python
packages in nixpkgs for test reasons).

This lets the package now build successfully with the recent pycodestyle 2.10.0
bump.
@bjornfor
Copy link
Contributor

Thanks!

@Shawn8901
Copy link
Contributor

Shawn8901 commented Dec 13, 2022

a Question from my side: Do we also need a backport for that? There is also autopep8 in v2.0.0 for pythonPackages310 in 22.11 and at least one machine, which should be on that is failing on building autopep with the same error as in the gist as far as i can tell.

@lilyinstarlight lilyinstarlight deleted the fix/autopep8 branch December 13, 2022 11:51
@lilyinstarlight
Copy link
Member Author

a Question from my side: Do we also need a backport for that? There is also autopep8 in v2.0.0 for pythonPackages310 in 22.11 and at least one machine, which should be on that is failing on building autopep with the same error as in the gist as far as i can tell.

I checked to make sure #203378 was not backported, since that is what caused the breaking change. It also looks like Hydra is still building it fine for 22.11: https://hydra.nixos.org/job/nixos/release-22.11/nixpkgs.python310Packages.autopep8.x86_64-linux

Are you sure that machine is on nixos-22.11?

@Shawn8901
Copy link
Contributor

You are right, it's my mistake. The machine is on 22.11 but the failing version is pulled by another flake, which does follow the unstable channel. So it's my bad. Thanks for double checking and clarification

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

python310Packages.autopep8: Build fails
3 participants