New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.autopep8: patch for pycodestyle-2.10.0 #205803
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks! But please put the PR description in the commit message, so the reasoning behind the change is stored in git.
ee48d63
to
734768b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: please end sentences in commit message with a dot.
This adjusts autopep8 to fetch from GitHub so it can be patched (patch does not apply cleanly to PyPI source tarball), and a test that had to be disabled because it was fetched from PyPI is re-enabled since it could work now (and as far as I understand, pulling from git is generally preferred for Python packages in nixpkgs for test reasons). This lets the package now build successfully with the recent pycodestyle 2.10.0 bump.
734768b
to
70165e2
Compare
Thanks! |
a Question from my side: Do we also need a backport for that? There is also autopep8 in v2.0.0 for pythonPackages310 in 22.11 and at least one machine, which should be on that is failing on building autopep with the same error as in the gist as far as i can tell. |
I checked to make sure #203378 was not backported, since that is what caused the breaking change. It also looks like Hydra is still building it fine for 22.11: https://hydra.nixos.org/job/nixos/release-22.11/nixpkgs.python310Packages.autopep8.x86_64-linux Are you sure that machine is on nixos-22.11? |
You are right, it's my mistake. The machine is on 22.11 but the failing version is pulled by another flake, which does follow the unstable channel. So it's my bad. Thanks for double checking and clarification |
Description of changes
This adjusts autopep8 to fetch from GitHub so it can be patched (patch does not apply cleanly to PyPI source tarball), and a test that had to be disabled because it was fetched from PyPI is re-enabled since it could work now (and as far as I understand, pulling from git is generally preferred for Python packages in nixpkgs for test reasons)
This lets the package now build successfully with the recent pycodestyle 2.10.0 bump in #203378
Closes #205733
Ref hhatto/autopep8#659 and hhatto/autopep8#661
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notesnixpkgs-review
Result of
nixpkgs-review pr 205803
run on x86_64-linux 120 packages built: