Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gofumpt: 0.3.1 -> 0.5.0 #196716

Closed
wants to merge 1 commit into from
Closed

Conversation

michaeladler
Copy link
Member

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ralismark
Copy link
Contributor

Result of nixpkgs-review pr 196716 run on x86_64-linux 1

1 package built:
  • gofumpt

Release info: https://github.com/mvdan/gofumpt/releases/tag/v0.4.0

Changelog

This release is based on Go 1.19's gofmt, and requires Go 1.18 or later.
We recommend building gofumpt with Go 1.19 for the best formatting results.

The jump from Go 1.18 brings diffing in pure Go, removing the need to exec diff,
and a small parsing speed-up thanks to go/parser.SkipObjectResolution.

The following formatting fixes are included as well:


My testing:

@michaeladler michaeladler changed the title gofumpt: 0.3.1 -> 0.4.0 gofumpt: 0.3.1 -> 0.5.0 Apr 21, 2023
@michaeladler
Copy link
Member Author

Updated to 0.5.0

@rafikdraoui
Copy link

ping @rvolosatovs

@katexochen
Copy link
Contributor

Done in #274237

@katexochen katexochen closed this Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants