Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkgsMusl.python3.pkgs.watchdog: fix build #192227

Merged
merged 1 commit into from Sep 21, 2022

Conversation

yu-re-ka
Copy link
Contributor

Description of changes

Works around a test making assumptions that are only fulfilled with glibc. Created an issue upstream: gorakhargosh/watchdog#920

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@superherointj
Copy link
Contributor

I confirm running pkgsMusl.python3.pkgs.watchdog:

  1. Fails at master
    image

  2. Builds fine with this PR.

@superherointj superherointj merged commit 1138e3d into NixOS:master Sep 21, 2022
@yu-re-ka yu-re-ka deleted the musl-pythyon-watchdog branch September 21, 2022 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants