libtiff: 4.3.0 -> 4.4.0

[kevinmehall]

Description of changes

New upstream release: http://www.simplesystems.org/libtiff/v4.4.0.html

Removed all CVE patches, since they reference commits in the history of the v4.4.0 tag.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • PENDING: libtiff.passthru.tests
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 22.11 Release Notes (or backporting 22.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[willcohen]

Looking forward! There've been some changes post-4.3.0 with building that I've been patching on some downstream projects in the meantime.

[kevinmehall]

Breaks freeimage-unstable-2021-11-01 build with:

Source/Metadata/XTIFF.cpp: In function 'BOOL tiff_write_exif_tags(TIFF*, TagLib::MDMODEL, FIBITMAP*)':
Source/Metadata/XTIFF.cpp:752:38: error: '_TIFFDataSize' was not declared in this scope; did you mean 'TIFFDataType'?
  752 |                         if((unsigned)_TIFFDataSize(tif_tag_type) != FreeImage_TagDataWidth(tag_type)) {
      |                                      ^~~~~~~~~~~~~
      |                                      TIFFDataType

freeimage is using a non-public libtiff API that was removed and replaced with a public API. This had already been reported on the freeimage forum and the libtiff mailing list. I'll try applying that patch.

[kevinmehall]

A pillow test also fails (Tests/test_file_libtiff.py:302: AssertionError) . Looks like python-pillow/Pillow#6339 may be needed to fix that.

[SuperSandro2000]

I am the pillow maintainer. Would be great if you could include that patch.

[L-as]

LGTM