Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python310Packages.sanic: enable since GHSA-7p79-6x2v-5h88 is resolved #166594

Closed
wants to merge 1 commit into from

Conversation

oati
Copy link
Contributor

@oati oati commented Mar 31, 2022

Description of changes

This commit reverts bf149c4, since GHSA-7p79-6x2v-5h88 only applies to sanic <20.12.6

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@risicle
Copy link
Contributor

risicle commented Apr 2, 2022

But have you seen what 20.12.6 does to "fix" it? sanic-org/sanic#2400

@oati
Copy link
Contributor Author

oati commented Apr 2, 2022

But have you seen what 20.12.6 does to "fix" it? sanic-org/sanic#2400

Oh, I never saw that :/

The reason I was looking into this was that spaCy depends on sanic, but nix fails to find sanic in 3.10. It looks like spaCy supports 3.10, so I'm wondering if this would still be worth it.

@risicle
Copy link
Contributor

risicle commented Apr 2, 2022

I guess it depends what it uses sanic for - probably worth a try though.

@oati
Copy link
Contributor Author

oati commented Apr 3, 2022

@risicle Looking at that patch more closely,

You should either use a supported version of Python (v3.6 - v3.9) or upgrade Sanic to v21+.

nixpkgs is on sanic version 21.12.1

@oati
Copy link
Contributor Author

oati commented May 3, 2022

@costrouc @AluisioASG

@ajs124
Copy link
Member

ajs124 commented Jul 7, 2022

superseded by c95ab3c

@ajs124 ajs124 closed this Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants